sql: detail the type for unsupported casts using "T() SCONST"

Release note: None
knz · Nov 28, 2018 · 4fad432 · 4fad432
1 parent bd3bce9
commit 4fad432
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/sql/parser/parse_test.go b/pkg/sql/parser/parse_test.go
@@ -2656,7 +2656,7 @@ func TestUnimplementedSyntax(t *testing.T) {
 		{`SELECT 'a'::INTERVAL SECOND(123)`, 0, `interval second with precision`},
 		{`SELECT (a,b) OVERLAPS (c,d)`, 0, `overlaps`},
 		{`SELECT UNIQUE (SELECT b)`, 0, `UNIQUE predicate`},
-		{`SELECT a(b) 'c'`, 0, `func const`},
+		{`SELECT a(b) 'c'`, 0, `a(...) SCONST`},
 		{`SELECT INTERVAL(3) 'a'`, 0, `expr_const const_interval`},
 		{`SELECT GROUPING (a,b,c)`, 0, `d_expr grouping`},
 		{`SELECT a(VARIADIC b)`, 0, `variadic`},

diff --git a/pkg/sql/parser/sql.y b/pkg/sql/parser/sql.y
@@ -7084,7 +7084,7 @@ d_expr:
   {
     $$.val = tree.NewBytesStrVal($1)
   }
-| func_name '(' expr_list opt_sort_clause_err ')' SCONST { return unimplemented(sqllex, "func const") }
+| func_name '(' expr_list opt_sort_clause_err ')' SCONST { return unimplemented(sqllex, $1.unresolvedName().String() + "(...) SCONST") }
 | const_typename SCONST
   {
     $$.val = &tree.CastExpr{Expr: tree.NewStrVal($2), Type: $1.colType(), SyntaxMode: tree.CastPrepend}