Skip to content

Commit

Permalink
importccl: reference cockroachdb#32560, cockroachdb#32559 and cockroa…
Browse files Browse the repository at this point in the history
…chdb#32561 for unimplemented types

Release note: None
  • Loading branch information
knz committed Nov 22, 2018
1 parent 8fecc9d commit 7d0f348
Showing 1 changed file with 8 additions and 4 deletions.
12 changes: 8 additions & 4 deletions pkg/ccl/importccl/read_import_mysql.go
Original file line number Diff line number Diff line change
Expand Up @@ -612,12 +612,16 @@ func mysqlColToCockroach(
def.Type = coltypes.JSON

case mysqltypes.Set:
fallthrough
return nil, pgerror.UnimplementedWithIssueHintError(32560,
"cannot import SET columns at this time",
"try converting the column to a 64-bit integer before import")
case mysqltypes.Geometry:
fallthrough
return nil, pgerror.UnimplementedWithIssueErrorf(32559,
"cannot import GEOMETRY columns at this time")
case mysqltypes.Bit:
// TODO(dt): is our type close enough to use here?
fallthrough
return nil, pgerror.UnimplementedWithIssueHintError(32561,
"cannot improt BIT columns at this time",
"try converting the column to a 64-bit integer before import")
default:
return nil, pgerror.Unimplemented(fmt.Sprintf("import.mysqlcoltype.%s", typ), "unsupported mysql type %q", col.Type)
}
Expand Down

0 comments on commit 7d0f348

Please sign in to comment.