Skip to content

Commit

Permalink
remove unnecessary step names and shell:bash
Browse files Browse the repository at this point in the history
  • Loading branch information
imjasonh committed Sep 22, 2021
1 parent a998edf commit af2867d
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 45 deletions.
11 changes: 3 additions & 8 deletions .github/workflows/modules-integration-test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,11 @@ jobs:
go-version: [1.16.x, 1.17.x]
runs-on: 'ubuntu-latest'
steps:
- name: Set up Go ${{ matrix.go-version }}
uses: actions/setup-go@v2
- uses: actions/setup-go@v2
with:
go-version: ${{ matrix.go-version }}
id: go
- uses: actions/checkout@v2

- name: Check out code
uses: actions/checkout@v2

- name: Test
env:
- env:
GOPATH: does not matter
run: ./integration_test.sh
16 changes: 4 additions & 12 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,20 +9,12 @@ jobs:
goreleaser:
runs-on: ubuntu-latest
steps:
-
name: Checkout
uses: actions/checkout@v2
-
name: Unshallow
run: git fetch --prune --unshallow
-
name: Set up Go
uses: actions/setup-go@v1
- uses: actions/checkout@v2
- run: git fetch --prune --unshallow
- uses: actions/setup-go@v1
with:
go-version: 1.17.x
-
name: Run GoReleaser
uses: goreleaser/goreleaser-action@v1
- uses: goreleaser/goreleaser-action@v1
with:
version: latest
args: release --rm-dist
Expand Down
30 changes: 5 additions & 25 deletions .github/workflows/style.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,10 @@ jobs:
importpath: golang.org/x/tools/cmd/goimports

steps:
- name: Set up Go 1.17.x
uses: actions/setup-go@v2
- uses: actions/setup-go@v2
with:
go-version: 1.17.x
id: go

- name: Check out code
uses: actions/checkout@v2
- uses: actions/checkout@v2

- name: Install Dependencies
if: ${{ matrix.importpath != '' }}
Expand All @@ -39,7 +35,6 @@ jobs:
GO111MODULE=on go get ${{ matrix.importpath }}
- name: ${{ matrix.tool }} ${{ matrix.options }}
shell: bash
run: >
${{ matrix.tool }} ${{ matrix.options }} -w
$(find .
Expand All @@ -50,7 +45,6 @@ jobs:
-o -type f -name '*.go' -print)
- name: Verify ${{ matrix.tool }}
shell: bash
run: |
# From: https://backreference.org/2009/12/23/how-to-match-newlines-in-sed/
# This is to leverage this workaround:
Expand All @@ -72,14 +66,10 @@ jobs:
runs-on: ubuntu-latest

steps:
- name: Set up Go 1.17.x
uses: actions/setup-go@v2
- uses: actions/setup-go@v2
with:
go-version: 1.17.x
id: go

- name: Check out code
uses: actions/checkout@v2
- uses: actions/checkout@v2

- name: Install Tools
env:
Expand All @@ -102,18 +92,11 @@ jobs:
echo "${TEMP_PATH}" >> $GITHUB_PATH
- id: golangci_configuration
uses: andstor/file-existence-action@v1
with:
files: .golangci.yaml
- name: Go Lint
if: steps.golangci_configuration.outputs.files_exists == 'true'
uses: golangci/golangci-lint-action@v2
- uses: golangci/golangci-lint-action@v2
with:
version: v1.38

- name: misspell
shell: bash
if: ${{ always() }}
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ github.token }}
Expand Down Expand Up @@ -141,7 +124,6 @@ jobs:
echo '::endgroup::'
- name: trailing whitespace
shell: bash
if: ${{ always() }}
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ github.token }}
Expand Down Expand Up @@ -170,7 +152,6 @@ jobs:
echo '::endgroup::'
- name: EOF newline
shell: bash
if: ${{ always() }}
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ github.token }}
Expand Down Expand Up @@ -213,7 +194,6 @@ jobs:
# since their action is not yet released under a stable version.
- name: Language
if: ${{ always() && github.event_name == 'pull_request' }}
shell: bash
env:
REVIEWDOG_GITHUB_API_TOKEN: ${{ github.token }}
run: |
Expand Down

0 comments on commit af2867d

Please sign in to comment.