Skip to content

Commit

Permalink
debug: build unsupported platforms with a warning
Browse files Browse the repository at this point in the history
Signed-off-by: Dan Luhring <dluhring@chainguard.dev>
  • Loading branch information
luhring committed Jun 10, 2024
1 parent 73a8a50 commit ff65ff7
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 6 deletions.
10 changes: 5 additions & 5 deletions pkg/build/gobuild.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,20 +309,18 @@ func getDelve(ctx context.Context, platform v1.Platform) (string, error) {
cloneDir := filepath.Join(tmpInstallDir, "delve")
err = os.MkdirAll(cloneDir, 0755)
if err != nil {
return "", fmt.Errorf("making dir for delve clone: %v", err)
return "", fmt.Errorf("making dir for delve clone: %w", err)
}
err = git.Clone(ctx, cloneDir, delveCloneURL)
if err != nil {
return "", fmt.Errorf("cloning delve repo: %v", err)
return "", fmt.Errorf("cloning delve repo: %w", err)
}
osArchDir := fmt.Sprintf("%s_%s", platform.OS, platform.Architecture)
delveBinaryPath := filepath.Join(tmpInstallDir, "bin", osArchDir, "dlv")

// install delve to tmp directory
args := []string{
"build",
"-C",
cloneDir,
"./cmd/dlv",
"-o",
delveBinaryPath,
Expand All @@ -331,6 +329,7 @@ func getDelve(ctx context.Context, platform v1.Platform) (string, error) {
gobin := getGoBinary()
cmd := exec.CommandContext(ctx, gobin, args...)
cmd.Env = env
cmd.Dir = cloneDir

var output bytes.Buffer
cmd.Stderr = &output
Expand Down Expand Up @@ -1003,6 +1002,7 @@ func (g *gobuild) buildOne(ctx context.Context, refStr string, base v1.Image, pl
}
}
if g.debug && !doesPlatformSupportDebugging(*platform) {
log.Printf("image for platform %q will be built without debugging enabled because debugging is not supported for that platform", *platform)
return nil, fmt.Errorf("debugging is not supported for %s", platform)
}

Expand Down Expand Up @@ -1116,7 +1116,7 @@ func (g *gobuild) buildOne(ctx context.Context, refStr string, base v1.Image, pl
})

delvePath := "" // path for delve in image
if g.debug {
if g.debug && doesPlatformSupportDebugging(*platform) {
// get delve locally
delveBinary, err := getDelve(ctx, *platform)
if err != nil {
Expand Down
38 changes: 37 additions & 1 deletion pkg/internal/git/clone.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,39 @@
// Copyright 2024 ko Build Authors All Rights Reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
// You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software
// distributed under the License is distributed on an "AS IS" BASIS,
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

// MIT License
//
// Copyright (c) 2016-2022 Carlos Alexandro Becker
//
// Permission is hereby granted, free of charge, to any person obtaining a copy
// of this software and associated documentation files (the "Software"), to deal
// in the Software without restriction, including without limitation the rights
// to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
// copies of the Software, and to permit persons to whom the Software is
// furnished to do so, subject to the following conditions:
//
// The above copyright notice and this permission notice shall be included in all
// copies or substantial portions of the Software.
//
// THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
// IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
// FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
// AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
// LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
// OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
// SOFTWARE.

package git

import (
Expand All @@ -18,7 +54,7 @@ func Clone(ctx context.Context, dir string, repoURL string) error {

_, err := run(ctx, rc)
if err != nil {
return fmt.Errorf("running git clone: %v", err)
return fmt.Errorf("running git clone: %w", err)
}

return nil
Expand Down

0 comments on commit ff65ff7

Please sign in to comment.