-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define common build tags to consume in .ko.yaml
#493
Comments
This issue is stale because it has been open for 90 days with no |
This seems reasonable to me, I just don't know if any current maintainers have any time to prioritize it. Maybe if someone reading this feels like throwing together a PR to get an idea for how it might work, that could be helpful. |
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Also re-run `go mod vendor` in order to use `testify`. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes #493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
This includes a number of template parameters supported by [goreleaser](https://goreleaser.com/customization/templates/). Specifically, the build date information and the majority of the Git params. Majority of the code is copied from goreleaser. I've added the MIT license from goreleaser at the top of the files. Fixes ko-build#493 Signed-off-by: Nathan Mittler <nmittler@aviatrix.com>
Since
.ko.yaml
is likely going to be used for more CI automation and releasing artifacts, it would be great to have access to common build variables, e.g.date/time
(RFC3339),commit
(short/long) and perhaps (git)tag
instead of having to manually create them in the environment to reference them in.ko.yaml
.I know this might be out of scope for
ko
due to reasons (e.g. relying ongit
) but just wanted to throw this out so people can find this issue and an answer why this won't be implemented or if this is something you think is useful for the project.Since
.ko.yaml
is inspired bygoreleaser
, we could reuse some of the standard build-related variables/templates (full list here).Example
.ko.yaml
idea:The text was updated successfully, but these errors were encountered: