Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ko resolve should exit error code when hitting 502 caused by docker repo issue #84

Closed
chaodaiG opened this issue Sep 18, 2019 · 6 comments · Fixed by #133
Closed

ko resolve should exit error code when hitting 502 caused by docker repo issue #84

chaodaiG opened this issue Sep 18, 2019 · 6 comments · Fixed by #133
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@chaodaiG
Copy link
Contributor

When hitting 502 caused by docker repo issue, ko resolve prints error message as stdout and exits 0, this should return non-zero exit code instead. The print line is here

See example here: https://prow.knative.dev/view/gcs/knative-prow/logs/ci-knative-serving-istio-1.1-mesh/1174030278339858432

Sample error message (Copy/pasted from link above):

2019/09/17 18:53:27 error processing import paths in "config/networking-istio.yaml": unsupported status code 502; body: <!DOCTYPE html>
<html lang=en>
  <meta charset=utf-8>
  <meta name=viewport content="initial-scale=1, minimum-scale=1, width=device-width">
  <title>Error 502 (Server Error)!!1</title>
  <style>
    *{margin:0;padding:0}html,code{font:15px/22px arial,sans-serif}html{background:#fff;color:#222;padding:15px}body{margin:7% auto 0;max-width:390px;min-height:180px;padding:30px 0 15px}* > body{background:url(//www.google.com/images/errors/robot.png) 100% 5px no-repeat;padding-right:205px}p{margin:11px 0 22px;overflow:hidden}ins{color:#777;text-decoration:none}a img{border:0}@media screen and (max-width:772px){body{background:none;margin-top:0;max-width:none;padding-right:0}}#logo{background:url(//www.google.com/images/branding/googlelogo/1x/googlelogo_color_150x54dp.png) no-repeat;margin-left:-5px}@media only screen and (min-resolution:192dpi){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat 0% 0%/100% 100%;-moz-border-image:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) 0}}@media only screen and (-webkit-min-device-pixel-ratio:2){#logo{background:url(//www.google.com/images/branding/googlelogo/2x/googlelogo_color_150x54dp.png) no-repeat;-webkit-background-size:100% 100%}}#logo{display:inline-block;height:54px;width:150px}
  </style>
  <a href=//www.google.com/><span id=logo aria-label=Google></span></a>
  <p><b>502.</b> <ins>That’s an error.</ins>
  <p>The server encountered a temporary error and could not complete your request.<p>Please try again in 30 seconds.  <ins>That’s all we know.</ins>
@chaodaiG chaodaiG mentioned this issue Sep 18, 2019
Closed
@jonjohnsonjr
Copy link
Collaborator

Are you using --watch?

@chaodaiG
Copy link
Contributor Author

Not afaik, unless implicitly. It's this file: https://github.com/knative/serving/blob/master/hack/generate-yamls.sh

@adrcunha
Copy link

All ko commands in the script above are something like:

ko resolve -P -f config/ --selector blablabla

@jonjohnsonjr
Copy link
Collaborator

Are you able to reproduce this reliably? I have a theory that the main thread is exiting with 0 after std.Output(2, fmt.Sprint(v...)) but before os.Exit(1) in log.Fatal.

We could just add a time.Sleep(1 * time.Millisecond) here. Or maybe instead of doing log.Fatal and just returning here, we could send an error on errCh if fo.Watch is unset, otherwise log.Printf.

@jonjohnsonjr jonjohnsonjr added good first issue Good for newcomers bug Something isn't working labels Oct 22, 2019
@jonjohnsonjr
Copy link
Collaborator

Actually we should probably just be using errgroup and Wait() before exiting.

This should just return an error, then we can handle it appropriately depending on if we're in watch mode or one-shot mode, instead of this hack.

@chaodaiG
Copy link
Contributor Author

Actually we should probably just be using errgroup and Wait() before exiting.

This should just return an error, then we can handle it appropriately depending on if we're in watch mode or one-shot mode, instead of this hack.

sgtm

@jonjohnsonjr jonjohnsonjr mentioned this issue Feb 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deterministically fail ko {apply, create} jonjohnsonjr/ko
3 participants
@jonjohnsonjr @adrcunha @chaodaiG