Deterministically fail ko {apply, create} #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When resolving files, we would just log.Fatal if we encountered an error. This seems to be racy and causes ko to exit with a 0 error code when it shouldn't. To fix this, we synchronize the builder goroutines with the kubectl go routine and exit with an error if either of them failed. This fix also happened to fix a goroutine leak. If the kubectl goroutine failed, we never properly cancelled the builds, which would happily conitnue compiling packages and consuming resources.
|
cc @chaodaiG |
|
LGTM |
|
Nice! Thank you a lot!
…On Mon, Feb 10, 2020, 9:31 PM Matt Moore ***@***.***> wrote:
LGTM
cc @imjasonh <https://github.com/ImJasonH>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#133>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKXNDYPJKG5WBGKJG7VQ3UDRCIZ4FANCNFSM4KSTMNFQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #84
When resolving files, we would just log.Fatal if we encountered an
error. This seems to be racy and causes ko to exit with a 0 error code
when it shouldn't. To fix this, we synchronize the builder goroutines
with the kubectl go routine and exit with an error if either of them
failed.
This fix also happened to fix a goroutine leak. If the kubectl goroutine
failed, we never properly cancelled the builds, which would happily
conitnue compiling packages and consuming resources.