Preserve YAML comments & style when resolving/applying #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is accomplished by adopting the yaml.v3 lib. It exposes a Node struct that's used internally by the yaml encoder/decoder ko internally now manipulates YAML documents using this struct Fixes ko-build#101
Fix comments Co-Authored-By: jonjohnsonjr <jonjohnson@google.com>
When the yaml.Decoder returns an io.EOF it implies there were no YAML documents decoded and that there are no more!
jonjohnsonjr
approved these changes
Oct 31, 2019
resolve comment suggestion Co-Authored-By: jonjohnsonjr <jonjohnson@google.com>
jonjohnsonjr
reviewed
Nov 5, 2019
jonjohnsonjr
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is accomplished by adopting the yaml.v3 lib. It
exposes a Node struct that's used internally by the
yaml encoder/decoder
ko now internally manipulates YAML documents using this struct
Fixes #101
At this time some comment formatting isn't 100% preserved see: go-yaml/yaml#533