Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Fix kind image loading for MacOS" #1054

Merged
merged 1 commit into from
May 23, 2023
Merged

Revert "Fix kind image loading for MacOS" #1054

merged 1 commit into from
May 23, 2023

Conversation

imjasonh
Copy link
Member

Reverts #1026

This failed unit tests: https://github.com/ko-build/ko/actions/runs/5058723077/jobs/9079218316

--- FAIL: TestWrite (0.02s)
    write_test.go:62: c.cmd = ctr --namespace=k8s.io images import --all-platforms -, want ctr --namespace=k8s.io images import -

@imjasonh imjasonh requested a review from jonjohnsonjr May 23, 2023 15:11
@imjasonh imjasonh enabled auto-merge (squash) May 23, 2023 15:11
@imjasonh imjasonh merged commit 27ca485 into main May 23, 2023
@imjasonh imjasonh deleted the revert-1026-fix_kind_macos branch May 23, 2023 15:14
@aidy aidy mentioned this pull request May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjasonh @jonjohnsonjr