-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --debug
build flag to include Delve debugger
#1148
Conversation
Hi @imjasonh, |
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1148 +/- ##
==========================================
+ Coverage 49.34% 49.87% +0.53%
==========================================
Files 44 44
Lines 3640 3743 +103
==========================================
+ Hits 1796 1867 +71
- Misses 1614 1637 +23
- Partials 230 239 +9
☔ View full report in Codecov by Sentry. |
Hello @jonjohnsonjr, |
Friendly reminder about this 😁 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, but I am not sure if we want to install this tool without any checks,
but i will defer to @imjasonh
15f5078
to
4007bd7
Compare
Rebased to solve merge conflicts. |
This Pull Request is stale because it has been open for 90 days with |
4007bd7
to
002f3cf
Compare
This Pull Request is stale because it has been open for 90 days with |
002f3cf
to
738c3b5
Compare
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
738c3b5
to
6778b74
Compare
This looks so cool!!!!! I see that conflicts have emerged over time, and I opened #1320 to see if we can get this across the finish line 🏁 |
Hey @luhring, |
This is merged! 🎉 Thank you for your patience, and happy debugging! 🐛 |
Currently the entrypoint of the image is always set to
/ko-app/<app-name>
. This makes it hard to remote debug the app via Delve, which invokes the app e.g. viadlv exec <path-to-app>
).This PR adds a new build flag (
--debug
), which adds the Delve debugger to the image and sets the entrypoint to invoke delve instead of the ko-app directly.Hint:
--disable-entrypoint-overwrite
option to allow to disable entrypoint overwrite #1138 (comment).How to test this PR:
debug
flag. e.g.ko apply --debug -f config/controller.yaml
kubectl port-forward deploy/my-controller 40000:40000