Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorder parsing KO_DOCKER_REPO to get proper credentials #117

Merged
merged 1 commit into from
Dec 18, 2019

Conversation

cezkuj
Copy link
Contributor

@cezkuj cezkuj commented Dec 18, 2019

Fixes #93

With this change we support also pointing to default registry (without prefix).
Eg. KO_DOCKER_REPO=myuser

Fixes ko-build#93

With this change we support also pointing to default registry (without prefix).
Eg. KO_DOCKER_REPO=myuser
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonjohnsonjr jonjohnsonjr merged commit 1fcfe62 into ko-build:master Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ko is unable to push to a registry with a host and port number
2 participants