Add kubectl Check for ko delete, apply, and create #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/commands/delete.go
Outdated
| @@ -46,6 +52,15 @@ func passthru(command string) runCmd { | |||
| } | |||
| } | |||
|
|
|||
| // check if kubectl is installed | |||
| func isKubectlAvailable() bool { | |||
| cmd := exec.Command("kubectl") | |||
There was a problem hiding this comment.
You could use exec.LookPath for this, and we probably want to do this for apply, create, and run as well.
There was a problem hiding this comment.
@jonjohnsonjr Awesome! I can definitely use LookPath instead. Thanks for the better suggestion. Would you recommend a good place to define isKubectlAvailable() so I can use it across all commands?
There was a problem hiding this comment.
Anywhere is fine! I'd just leave it here, probably.
There was a problem hiding this comment.
I put in commands.go for now, but more than willing to move it back to any of the commands that use it.
danielhelfand
force-pushed
the
kubectl_check
branch
from
7b0e393 to
2ef3f5c
Compare
danielhelfand
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds an error message in case
kubectlis not installed. I'm assuming most users ofkowill havekubectlinstalled, but it's nice to have a clear message in the edge case when it's not available.