Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug: separate target and delve parameters #1368

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

zregvart
Copy link
Contributor

Adds the -- separator parameter so delve doesn't try to parse any command line parameters intended for the target binary.

Copy link

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please can we move forward with this? 🙏

@cpanato
Copy link
Member

cpanato commented Sep 25, 2024

need a rebase

@phisco
Copy link

phisco commented Sep 25, 2024

@zregvart it would be awesome if you could rebase this 🙏

Adds the `--` separator parameter so delve doesn't try to parse any
command line parameters intended for the target binary.
Copy link

@phisco phisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @zregvart! CC @cpanato 🙏

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit 08c82b9 into ko-build:main Oct 8, 2024
20 of 21 checks passed
@zregvart zregvart deleted the pr/dlv-param-separation branch October 9, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants