-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration tests for various go mod corner cases. #179
Conversation
I realize now this is run in a travis CI job :) So I'll make it actually work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if we'll always want to keep this exact behavior, but having a test is nice to know if we change it 😄 lgtm once you fix the build failures
Oh, because it's not actually obvious: I wrote the test cases before checking behavior :) So at least I'm convinced this behavior is correct. |
Same error :/ I think you need a build tag that doesn't get used so that it doesn't try to build it, we did something similar in go-containerregistry: https://github.com/google/go-containerregistry/pull/599/files#diff-39bad9c50a0f30bd6c067b83431bec76R1 |
Ah, I missed that I didn't have the tools build tag, yeah that's definitely necessary. |
Any suggestions on what to set for KO_DOCKER_REPO ? |
I think the current integration tests use the |
Ah, perfect, that works for me, thank you :) |
Ready! I think :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, I don't think I would have had to patience :)
"Fixes" #171 (where I was confused by the behavior of modules) by ensuring ko behaves similarly to go build in various edge cases.