Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin k8s.io/api for good measure #188

Merged
merged 1 commit into from
Sep 4, 2020
Merged

Pin k8s.io/api for good measure #188

merged 1 commit into from
Sep 4, 2020

Conversation

mattmoor
Copy link
Collaborator

@mattmoor mattmoor commented Sep 4, 2020

No description provided.

@mattmoor
Copy link
Collaborator Author

mattmoor commented Sep 4, 2020

I was comparing vendor/k8s.io with what we have replace directives for, and everything else was present or doesn't have a 0.18.8 tag (one had a release-1.18 branch, but no tag 😞 )

@mattmoor
Copy link
Collaborator Author

mattmoor commented Sep 4, 2020

whoops forgot go mod vendor!

@mattmoor
Copy link
Collaborator Author

mattmoor commented Sep 4, 2020

Alright, should be rfal 🤞

@jonjohnsonjr jonjohnsonjr merged commit 1e05e91 into ko-build:master Sep 4, 2020
@mattmoor mattmoor deleted the pin-api-too branch September 4, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@imjasonh imjasonh

@jonjohnsonjr jonjohnsonjr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattmoor @jonjohnsonjr @imjasonh