Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix base image resolution #201

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

mattmoor
Copy link
Collaborator

I noticed that my .ko.yaml was being ignored because it was looking for ko:// prefixed things.

I also tried this with ko publish three ways: ko://-prefixed, non-ko:// prefixed, and relative path, and all picked up the appropriate base.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #201   +/-   ##
=======================================
  Coverage   37.82%   37.82%           
=======================================
  Files          33       33           
  Lines        1380     1380           
=======================================
  Hits          522      522           
  Misses        768      768           
  Partials       90       90           
Impacted Files Coverage Δ
pkg/commands/config.go 15.49% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5af0bc1...0498f38. Read the comment docs.

@mattmoor mattmoor merged commit d487673 into ko-build:master Sep 25, 2020
@mattmoor mattmoor deleted the normalize-base-image branch September 25, 2020 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants