Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Automated] Update actions #213

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

mattmoor
Copy link
Collaborator

@mattmoor mattmoor commented Oct 1, 2020

Produced via:

# meta: knative/.github
# main: google/ko
cp $(find "${GITHUB_WORKSPACE}/meta/workflow-templates" -type f -name '*.yaml') \
  "${GITHUB_WORKSPACE}/main/.github/workflows/"

/cc @jonjohnsonjr @imjasonh
/assign @jonjohnsonjr @imjasonh

# and sometimes we have (e.g. configmap checksum).
echo "Found diffs in: $(git diff-index --name-only HEAD --)"
for x in $(git diff-index --name-only HEAD --); do
echo "::error file=$x::Please run ./hack/update-codegen.sh.%0A$(git diff $x | urlencode)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this apply to this repo?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it will be a nop action, all of the codegen checks predicate on the existence of that file, but we don't have a way to avoid syncing particular actions currently 😅

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2020

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   37.05%   37.05%           
=======================================
  Files          33       33           
  Lines        1414     1414           
=======================================
  Hits          524      524           
  Misses        800      800           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e780390...25a02ee. Read the comment docs.

@mattmoor mattmoor force-pushed the auto-updates/common-actions branch 5 times, most recently from 99dcbf3 to f8b4e30 Compare October 9, 2020 01:42
@mattmoor
Copy link
Collaborator Author

We should probably fix the assorted issues the linter found: https://github.com/google/ko/actions/runs/296614452

@imjasonh
Copy link
Member

This fails some lint checks: https://github.com/google/ko/pull/213/checks?check_run_id=1229144464

Can we get those fixed or ignored before imposing this requirement?

@markusthoemmes
Copy link
Contributor

@mattmoor @imjasonh #222 fixes the linting issues.

@codecov-io
Copy link

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   37.05%   37.05%           
=======================================
  Files          33       33           
  Lines        1414     1414           
=======================================
  Hits          524      524           
  Misses        800      800           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c4d755...1e10df1. Read the comment docs.

Signed-off-by: Matt Moore (via Sockpuppet) <mattmoor@vmware.com>
@imjasonh imjasonh merged commit 28a36d6 into ko-build:master Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants