-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Automated] Update actions #213
[Automated] Update actions #213
Conversation
# and sometimes we have (e.g. configmap checksum). | ||
echo "Found diffs in: $(git diff-index --name-only HEAD --)" | ||
for x in $(git diff-index --name-only HEAD --); do | ||
echo "::error file=$x::Please run ./hack/update-codegen.sh.%0A$(git diff $x | urlencode)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this apply to this repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it will be a nop action, all of the codegen checks predicate on the existence of that file, but we don't have a way to avoid syncing particular actions currently 😅
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 37.05% 37.05%
=======================================
Files 33 33
Lines 1414 1414
=======================================
Hits 524 524
Misses 800 800
Partials 90 90 Continue to review full report at Codecov.
|
99dcbf3
to
f8b4e30
Compare
We should probably fix the assorted issues the linter found: https://github.com/google/ko/actions/runs/296614452 |
This fails some lint checks: https://github.com/google/ko/pull/213/checks?check_run_id=1229144464 Can we get those fixed or ignored before imposing this requirement? |
f8b4e30
to
1e10df1
Compare
Codecov Report
@@ Coverage Diff @@
## master #213 +/- ##
=======================================
Coverage 37.05% 37.05%
=======================================
Files 33 33
Lines 1414 1414
=======================================
Hits 524 524
Misses 800 800
Partials 90 90 Continue to review full report at Codecov.
|
Signed-off-by: Matt Moore (via Sockpuppet) <mattmoor@vmware.com>
1e10df1
to
2d9942c
Compare
Produced via:
/cc @jonjohnsonjr @imjasonh
/assign @jonjohnsonjr @imjasonh