-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the publish.Namer, add --bare
option for image naming
#234
Conversation
ad5c18f
to
77ca9d1
Compare
--naked
option for image naming
For example with ECR, my registry domain is With this, I can use In these cases, no part of the import path is incorporated into the repository name, which is where the name "naked" comes from. I'm open to alternative naming suggestions, but struggled to find a more descriptive term than this. |
@imjasonh also doesn't like the name either. He suggested I am happy to switch to |
I'd prefer dropping the short flag regardless, since they're such a precious resource. In fact, it would be great if this was really cumbersome to type so that you got annoyed into implementing a better mechanism for this :) Some dumb ideas that might inspire better ideas:
In this mode, we should probably warn or error if you pass a single tag and we publish multiple images, because the tag will get overwritten. Alternatively (lazily), just document this caveat in the README or flag description. |
--naked
option for image naming--bare
option for image naming
In some environments (e.g. ECR) each repository needs to be pre-created, which gets tedious.
Given that
ko
does everything by digest, this collapses all of the images published into the same repository:${KO_DOCKER_REPO}
with no suffix to discriminate between images.This is also beneficial from a security standpoint in certain contexts, as
KO_DOCKER_REPO=docker.io/{user}
might publish new repositories as public by default.