Set GOARM based on platform.variant #239
Conversation
pkg/build/gobuild_test.go
Outdated
| variant, err := getGoarm(tc.platform) | ||
| if tc.err { | ||
| if err == nil { | ||
| t.Errorf("getGoarm expected err for: %v", tc.platform) |
There was a problem hiding this comment.
you tripped the Victor linter
There was a problem hiding this comment.
What do I do??
There was a problem hiding this comment.
I vehemently disagree with this.
There was a problem hiding this comment.
cc @vagababov
This has the error message that doesn't show the correct suggestion.
There was a problem hiding this comment.
t.Error("getGoarm...:", tc.Platform) is what it wants
There was a problem hiding this comment.
I fixed it my own way!
Codecov Report
@@ Coverage Diff @@
## master #239 +/- ##
==========================================
+ Coverage 36.78% 37.19% +0.41%
==========================================
Files 33 33
Lines 1441 1460 +19
==========================================
+ Hits 530 543 +13
- Misses 822 828 +6
Partials 89 89
Continue to review full report at Codecov.
|
This relies on some hard-coded knowledge of the go compiler, which is unfortunate, so we will have to update this if things change.
This relies on some hard-coded knowledge of the go compiler, which is
unfortunate, so we will have to update this if things change.
Fixes #235
{ "schemaVersion": 2, "mediaType": "application/vnd.docker.distribution.manifest.list.v2+json", "manifests": [ { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 1737, "digest": "sha256:6f777bfc2417d9282b981aef39049a45e3a97049106fbfc9265dc5245fa3ec89", "platform": { "architecture": "amd64", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 1737, "digest": "sha256:225dcfc690d5d677e7ac71b9261cf8d7c82606c551ce14c87bb9b4f32b826610", "platform": { "architecture": "arm", "os": "linux", "variant": "v5" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 1736, "digest": "sha256:5d0e62c2b235271442d9eca9c851914bed3e0ba9c1298b517b270e34d80dcf6f", "platform": { "architecture": "arm", "os": "linux", "variant": "v7" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 1736, "digest": "sha256:bf35a275d966f45a4a57ab31cf016b16fef49e544edd603547a5193a4dc91e1b", "platform": { "architecture": "arm64", "os": "linux", "variant": "v8" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 1738, "digest": "sha256:a5ee0f4a4d800ea0384618e6fc0ea6c9efb46b3434e7496c059e8685a8923006", "platform": { "architecture": "386", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 1738, "digest": "sha256:20614018734dd0ccf48a31a05a5ae1c40d09192ec54b1b11da3148fa3ea94628", "platform": { "architecture": "mips64le", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 1737, "digest": "sha256:c918d36a05ccc8513481ce94558faa9c9f4778a22ca7e3a3433bb5745e74c312", "platform": { "architecture": "ppc64le", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 1737, "digest": "sha256:07bd970a225acdd2ddf66dc951dba1072be8075d0f95928b35bdc10488e3fcac", "platform": { "architecture": "s390x", "os": "linux" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 2993, "digest": "sha256:10e100bd95487f9c4b268f38d7a708e04ab5aa6ca30cdce6ebea065c7f180516", "platform": { "architecture": "amd64", "os": "windows", "os.version": "10.0.17763.1518" } }, { "mediaType": "application/vnd.docker.distribution.manifest.v2+json", "size": 2916, "digest": "sha256:c9e8ab3b00eaca483d3784720c5072b1516129eb97d09911a74c43ad89973933", "platform": { "architecture": "amd64", "os": "windows", "os.version": "10.0.14393.3986" } } ] }Note that the last layer is the binary:
The last layers are different, which indicates that we build different artifacts based on the variant: