Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving #21 issue. Adding ko version and simple release script #25

Merged
merged 3 commits into from
May 17, 2019
Merged

Resolving #21 issue. Adding ko version and simple release script #25

merged 3 commits into from
May 17, 2019

Conversation

cezkuj
Copy link
Contributor

@cezkuj cezkuj commented Apr 16, 2019

Output from version command implemented as we have discussed in comments, easily we can extend it with other build information from govvv, if needed.
Also, added basic release script, I didn't have any guidelines so I added what seemed valid for me, let's discuss if it should be improved.
Cheers!

hack/release.sh Outdated Show resolved Hide resolved
@cezkuj
Copy link
Contributor Author

cezkuj commented May 12, 2019

@jonjohnsonjr @imjasonh

I've updated branch so it doesn't have conflicts anymore. Could you review it?

@imjasonh
Copy link
Member

I think we want to run git rev-parse in ko's directory in GOPATH, not in the current working directory, which is probably another repo and not ko's.

@cezkuj
Copy link
Contributor Author

cezkuj commented May 12, 2019

Hmm, agreed but, using GOPATH wouldn't be possible if migrated to go modules. It is definitely drawback - not sure if valid for now.

For the time being we could use git dir based on GOPATH. Smth like that:

gitDir := fmt.Sprintf("--git-dir=%v/src/github.com/google/ko/.git", os.Getenv("GOPATH"))
hash, err := exec.Command("git", gitDir, "rev-parse", "HEAD").Output()

@imjasonh imjasonh merged commit 8a084cb into ko-build:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants