Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctx everywhere #268

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

I noticed that hitting ctrl-C didn't work when pushing images, this should fix that.

I noticed that hitting ctrl-C didn't work when pushing images, this
should fix that.
@codecov-io
Copy link

Codecov Report

Merging #268 (7b3d17c) into master (960e6a3) will not change coverage.
The diff coverage is 80.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #268   +/-   ##
=======================================
  Coverage   36.89%   36.89%           
=======================================
  Files          33       33           
  Lines        1461     1461           
=======================================
  Hits          539      539           
  Misses        833      833           
  Partials       89       89           
Impacted Files Coverage Δ
pkg/commands/publisher.go 0.00% <0.00%> (ø)
pkg/commands/resolver.go 12.42% <ø> (ø)
pkg/internal/testing/fixed.go 69.56% <ø> (ø)
pkg/publish/daemon.go 32.00% <ø> (ø)
pkg/publish/kind.go 0.00% <ø> (ø)
pkg/publish/layout.go 44.11% <ø> (ø)
pkg/publish/tarball.go 63.88% <ø> (ø)
pkg/publish/default.go 63.49% <100.00%> (ø)
pkg/publish/multi.go 60.00% <100.00%> (ø)
pkg/publish/shared.go 93.75% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 960e6a3...7b3d17c. Read the comment docs.

@jonjohnsonjr jonjohnsonjr changed the title Add ctx to publish.Interface Add ctx everywhere Dec 15, 2020
@jonjohnsonjr jonjohnsonjr merged commit 522c37c into ko-build:master Dec 21, 2020
@jonjohnsonjr jonjohnsonjr deleted the publish-context branch December 21, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants