Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ko login #277

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Add ko login #277

merged 1 commit into from
Dec 22, 2020

Conversation

jonjohnsonjr
Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr commented Dec 22, 2020

Fixes #155

This was previously ko auth login, which I've hidden, and perhaps we
can alias to ko login in the future, but in theory folks could have
been using ko auth get, and I don't want to break that for no reason.

@google-cla google-cla bot added the cla: yes label Dec 22, 2020
@codecov-io
Copy link

Codecov Report

Merging #277 (edcabad) into master (fd5cd4b) will increase coverage by 1.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
+ Coverage   36.84%   37.88%   +1.04%     
==========================================
  Files          33       33              
  Lines        1463     1507      +44     
==========================================
+ Hits          539      571      +32     
- Misses        835      845      +10     
- Partials       89       91       +2     
Impacted Files Coverage Δ
pkg/commands/resolver.go 11.60% <0.00%> (-0.83%) ⬇️
pkg/commands/config.go 15.94% <0.00%> (+0.87%) ⬆️
pkg/build/options.go 85.71% <0.00%> (+2.38%) ⬆️
pkg/build/gobuild.go 60.66% <0.00%> (+2.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd5cd4b...edcabad. Read the comment docs.

This was previously `ko auth login`, which I've hidden, and perhaps we
can alias to `ko login` in the future, but in theory folks could have
been using `ko auth get`, and I don't want to break that for no reason.
@jonjohnsonjr jonjohnsonjr marked this pull request as ready for review December 22, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ko login
3 participants