Always use "strict" mode #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We dropped this flag, so we're always in non-strict mode by default, so if there is a ko:// reference that fails to build, we don't error out. This drops some guards so that we are always in strict mode and only build ko:// things.
mattmoor
approved these changes
Dec 22, 2020
imjasonh
approved these changes
Dec 22, 2020
slinkydeveloper
added a commit
to slinkydeveloper/eventing-kafka-broker
that referenced
this pull request
Mar 18, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
knative-prow-robot
pushed a commit
to knative-extensions/eventing-kafka-broker
that referenced
this pull request
Mar 18, 2021
Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We dropped this flag, so we're always in non-strict mode by default,
so if there is a ko:// reference that fails to build, we don't error
out. This drops some guards so that we are always in strict mode and
only build ko:// things.
I had assumed this was already the state of things, but it wasn't!
cc @imjasonh am I missing something?