Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options: update --bare help message #313

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

zhouhaibing089
Copy link
Contributor

The current --bare help message is a little bit confusing: It says
that it will not work with --tags properly, but in fact, I would
assume it means that it may not work properly instead.

With --bare, the name will be ${KO_DOCKER_REPO}:<tag>.

@google-cla
Copy link

google-cla bot commented Feb 18, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Feb 18, 2021
@codecov-io
Copy link

Codecov Report

Merging #313 (bc35bbc) into main (8e1aaa1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   38.07%   38.07%           
=======================================
  Files          33       33           
  Lines        1513     1513           
=======================================
  Hits          576      576           
  Misses        844      844           
  Partials       93       93           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e1aaa1...bc35bbc. Read the comment docs.

@imjasonh
Copy link
Member

cc @mattmoor who added this iirc

@mattmoor
Copy link
Collaborator

This seems fine to me.

The current `--bare` help message is a little bit confusing: It says
that it will not work with `--tags` properly, but in fact, I would
assume it means that it may not work properly instead.

With `--bare`, the name will be `${KO_DOCKER_REPO}:<tag>`.
@google-cla google-cla bot added cla: yes and removed cla: no labels Feb 19, 2021
@imjasonh imjasonh merged commit 5eef982 into ko-build:main Apr 8, 2021
@zhouhaibing089 zhouhaibing089 deleted the update-bare-comment branch June 3, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants