Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap io errs for kodata layer #320

Merged
merged 2 commits into from
Feb 25, 2021
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #319

This is untested. The new io/fs stuff might make this easier, but I'm too lazy to try it out.

@benmoss would this have helped?

@google-cla google-cla bot added the cla: yes label Feb 24, 2021
@codecov-io
Copy link

Codecov Report

Merging #320 (c639cb7) into main (a6442e6) will decrease coverage by 0.09%.
The diff coverage is 12.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #320      +/-   ##
==========================================
- Coverage   38.07%   37.97%   -0.10%     
==========================================
  Files          33       33              
  Lines        1513     1514       +1     
==========================================
- Hits          576      575       -1     
- Misses        844      845       +1     
- Partials       93       94       +1     
Impacted Files Coverage Δ
pkg/build/gobuild.go 59.24% <12.50%> (-0.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6442e6...c639cb7. Read the comment docs.

@benmoss
Copy link
Contributor

benmoss commented Feb 25, 2021

Not much because of the re-assignment of hostPath on the line immediately preceding where you print it :)

2021/02/25 11:41:43 error processing import paths in "config/core/999-cache.yaml": error resolving image references: filepath.EvalSymlinks(""): not a directory

@jonjohnsonjr
Copy link
Collaborator Author

Not much because of the re-assignment of hostPath on the line immediately preceding where you print it :)

🤦

One more try? 😄

@benmoss
Copy link
Contributor

benmoss commented Feb 25, 2021

yay

2021/02/25 12:07:26 error processing import paths in "config/core/999-cache.yaml": error resolving image references: filepath.EvalSymlinks("/home/cesium/workspace/serving/cmd/queue/kodata/HEAD"): not a directory

@jonjohnsonjr jonjohnsonjr merged commit ee74460 into ko-build:main Feb 25, 2021
@jonjohnsonjr jonjohnsonjr deleted the fs-errors branch February 25, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Obscure error when encountering a bad symlink
4 participants