-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a tag-only flag to publisher. #332
Conversation
a615999
to
1699349
Compare
I'm not sure I understand the use case, in what cases are references by digest not preferred? Images by tag are problematic because the tag can change and you can get unexpected/inconsistent behavior across replicas/nodes. |
I can imagine a couple situations where this could be useful, e.g. when writing to the docker daemon, but not when pushing to the registry. Agree with Jason, I'd like to understand the problem a little more. |
1699349
to
ab03af6
Compare
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
==========================================
+ Coverage 38.24% 38.39% +0.14%
==========================================
Files 33 33
Lines 1527 1542 +15
==========================================
+ Hits 584 592 +8
- Misses 849 853 +4
- Partials 94 97 +3
Continue to review full report at Codecov.
|
Sure I could explain more. Our use case is to use |
In general I agree that image digests are preferred, just that it doesn't work in this particular use case. I also put a constraint for this tag to disallow people from generating image references that uses the (commonly) moving |
ab03af6
to
568df19
Compare
I'm not sure if we want to be that opinionated about I'm ok to merge unless @imjasonh has objections |
Sgtm |
The
--tag-only
flag resolves images into tag-only references. This flag is useful when digests are not preserved when images are repopulated. It can only be used when a single tag is specified, and the tag is notlatest
.