Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for ko.local in the daemon #371

Merged
merged 2 commits into from
Jun 9, 2021
Merged

Conversation

jonjohnsonjr
Copy link
Collaborator

Fixes #368

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2021

Codecov Report

Merging #371 (229b6b4) into main (23ecf47) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
- Coverage   43.43%   43.38%   -0.06%     
==========================================
  Files          33       33              
  Lines        1570     1572       +2     
==========================================
  Hits          682      682              
- Misses        760      761       +1     
- Partials      128      129       +1     
Impacted Files Coverage Δ
pkg/commands/config.go 53.75% <0.00%> (-1.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23ecf47...229b6b4. Read the comment docs.

@imjasonh
Copy link
Member

Can you also add this to the docs? We might want a quick example of building a base image locally then ko-publishing on top of it, and the ko.local convention would be useful to spell out.

@jonjohnsonjr
Copy link
Collaborator Author

a quick example of ...

We might want a directory with examples to avoid polluting the README? Would also be nice for getting started. Too lazy to do that for this PR :)

Copy link

@misterikkit misterikkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other places where a ref to ko.local might not resolve to the daemon? Eventually, it would be nice to have a consistent "ko.local means daemon" behavior across all surfaces.

@jonjohnsonjr
Copy link
Collaborator Author

I think this covers everything. We pull base images and push built images, and the base image side probably doesn't receive as much love because (usually) the distroless default base is good enough.

@jonjohnsonjr
Copy link
Collaborator Author

@imjasonh ptal

@jonjohnsonjr jonjohnsonjr merged commit 82e899d into ko-build:main Jun 9, 2021
@jonjohnsonjr jonjohnsonjr deleted the local-base branch June 9, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: custom base image from local docker daemon
4 participants