-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Look for ko.local in the daemon #371
Conversation
Codecov Report
@@ Coverage Diff @@
## main #371 +/- ##
==========================================
- Coverage 43.43% 43.38% -0.06%
==========================================
Files 33 33
Lines 1570 1572 +2
==========================================
Hits 682 682
- Misses 760 761 +1
- Partials 128 129 +1
Continue to review full report at Codecov.
|
Can you also add this to the docs? We might want a quick example of building a base image locally then ko-publishing on top of it, and the |
We might want a directory with examples to avoid polluting the README? Would also be nice for getting started. Too lazy to do that for this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other places where a ref to ko.local
might not resolve to the daemon? Eventually, it would be nice to have a consistent "ko.local means daemon" behavior across all surfaces.
I think this covers everything. We pull base images and push built images, and the base image side probably doesn't receive as much love because (usually) the distroless default base is good enough. |
@imjasonh ptal |
Fixes #368