Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update "go install" instructions #377

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Update "go install" instructions #377

merged 1 commit into from
Jul 27, 2021

Conversation

xuhdev
Copy link
Contributor

@xuhdev xuhdev commented Jun 28, 2021

I got the following error when following the original instructions:

go install: version is required when current directory is not in a module
        Try 'go install github.com/google/ko@latest' to install the latest version

@google-cla
Copy link

google-cla bot commented Jun 28, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

imjasonh
imjasonh previously approved these changes Jun 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #377 (ffae306) into main (ee23538) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #377   +/-   ##
=======================================
  Coverage   44.04%   44.04%           
=======================================
  Files          33       33           
  Lines        1605     1605           
=======================================
  Hits          707      707           
  Misses        769      769           
  Partials      129      129           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee23538...ffae306. Read the comment docs.

@imjasonh
Copy link
Member

Sorry for the long delay on this PR. We had an issue with kind e2e tests that was resolved in #184 -- if you rebase you should pick it up, and tests should pass, and we can merge this. Otherwise I'd be happy to make the change myself.

I got the following error when following the original instructions:

    go install: version is required when current directory is not in a module
            Try 'go install github.com/google/ko@latest' to install the latest version
@imjasonh imjasonh merged commit 1809666 into ko-build:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants