Enable overriding docker client #378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 2, 2021
imjasonh
previously approved these changes
Jul 2, 2021
|
Thanks for the quick review @imjasonh ! Looks like the kind e2e tests fail because of issues setting up the kind clusters. I can see this in the logs: |
jonjohnsonjr
reviewed
Jul 2, 2021
| @@ -35,10 +35,12 @@ const ( | |||
| ) | |||
|
|
|||
| // demon is intentionally misspelled to avoid name collision (and drive Jon nuts). | |||
| // [Narrator: Jon wasn't the only one driven nuts.] | |||
|
I don't understand why the kind tests are failing |
|
@halvards want to rebase this to pick up kind fix? |
When embedding ko, it may be necessary to override the docker client. This adds a PublishOption to inject a docker client created elsewhere. Ko will use this client to interact with the docker daemon. Context: GoogleContainerTools/skaffold#6054 (comment)
halvards
force-pushed
the
client-publish-option
branch
from
1c3c01e
to
d2d6abd
Compare
|
kind e2e tests passing. Thanks @imjasonh and @jonjohnsonjr! |
imjasonh
approved these changes
Jul 15, 2021
jonjohnsonjr
approved these changes
Jul 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When embedding ko, it may be necessary to override the docker client.
This adds a PublishOption to inject a docker client created elsewhere.
Ko will use this client to interact with the docker daemon.
Context: GoogleContainerTools/skaffold#6054 (comment)