Enable setting environment variables in .ko.yaml #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imjasonh
reviewed
Aug 18, 2021
README.md
Outdated
| @@ -144,6 +146,8 @@ builds: | |||
| - -X main.version={{.Env.VERSION}} | |||
| - id: bar | |||
| main: ./foobar/bar/main.go | |||
| env: | |||
| - CGO_ENABLED=1 | |||
There was a problem hiding this comment.
We don't tend to support cgo well, can we use another example here instead?
There was a problem hiding this comment.
Good point, changed to GOCACHE.
|
Should I commit the changes in |
halvards
added a commit
to halvards/ko
that referenced
this pull request
Aug 19, 2021
Enables programmatically overriding build configs when ko is embedded in another tool. Related: ko-build#340, ko-build#419
jonjohnsonjr
previously approved these changes
Aug 19, 2021
|
I think this just needs a rebase. |
Matches the GoReleaser format. Related: ko-build#340
halvards
added a commit
to halvards/ko
that referenced
this pull request
Aug 22, 2021
Enables programmatically overriding build configs when ko is embedded in another tool. Related: ko-build#340, ko-build#419
|
Rebased, but Travis CI complains about the s390x build. Other archs seem fine, and the other PR has the same problem. |
Frustrating :/ just going to merge this anyway but we should probably just drop travis. |
halvards
added a commit
to halvards/ko
that referenced
this pull request
Aug 25, 2021
Enables programmatically overriding build configs when ko is embedded in another tool. Related: ko-build#340, ko-build#419
jonjohnsonjr
pushed a commit
that referenced
this pull request
Aug 26, 2021
* Set build config via BuildOptions Enables programmatically overriding build configs when ko is embedded in another tool. Related: #340, #419 * Use local registry for base images in unit tests Tests create a local registry (using ggcr) with a dummy base image. This speeds up tests, since they don't need to hit gcr.io to fetch the default distroless base image. * Update function comment to refer to random image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Matches the GoReleaser format.
Related: #340