Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up base image unit test with local registry #429

Merged
merged 1 commit into from
Aug 27, 2021

Conversation

halvards
Copy link
Collaborator

Also follow my own advice to defer Close() 😇

Also follow my own advice to `defer Close()` 😇
@google-cla google-cla bot added the cla: yes label Aug 27, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #429 (a83e016) into main (ae594dc) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #429      +/-   ##
==========================================
- Coverage   53.50%   53.28%   -0.22%     
==========================================
  Files          36       36              
  Lines        1828     1828              
==========================================
- Hits          978      974       -4     
- Misses        699      703       +4     
  Partials      151      151              
Impacted Files Coverage Δ
pkg/commands/config.go 55.96% <0.00%> (-3.67%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae594dc...a83e016. Read the comment docs.

@halvards halvards requested a review from jonjohnsonjr August 27, 2021 04:34
@jonjohnsonjr jonjohnsonjr merged commit 29fccb0 into ko-build:main Aug 27, 2021
@halvards halvards deleted the repeat-local-repo-trick branch August 28, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants