Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to Go 1.16.x #435

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Bump to Go 1.16.x #435

merged 1 commit into from
Sep 13, 2021

Conversation

mattmoor
Copy link
Collaborator

Go 1.16 introduces "embed", which folks are starting to adopt.

Folks are also starting to use things from io instead of ioutil, which is another 1.16 change I've seen folks picking up without even realizing it.

@google-cla google-cla bot added the cla: yes label Sep 13, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2021

Codecov Report

Merging #435 (c8e2ca3) into main (7f145a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #435   +/-   ##
=======================================
  Coverage   53.43%   53.43%           
=======================================
  Files          36       36           
  Lines        1834     1834           
=======================================
  Hits          980      980           
  Misses        703      703           
  Partials      151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f145a7...c8e2ca3. Read the comment docs.

@@ -10,7 +10,7 @@ jobs:
name: Module Tests
strategy:
matrix:
go-version: [1.14.x, 1.15.x]
go-version: [1.16.x]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #405

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to steal the change I made to the script's go get?

@mattmoor mattmoor merged commit 501111b into ko-build:main Sep 13, 2021
@mattmoor mattmoor deleted the go-1-16 branch September 13, 2021 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants