Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable codeql analysis #457

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Oct 1, 2021

These were dropped in #364 and I don't remember why. The result is that code scanning alerts have been disabled since May: https://github.com/google/ko/security/code-scanning

@imjasonh imjasonh requested a review from jonjohnsonjr October 1, 2021 15:08
@google-cla google-cla bot added the cla: yes label Oct 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #457 (a233982) into main (688ca47) will not change coverage.
The diff coverage is n/a.

❗ Current head a233982 differs from pull request most recent head 757233c. Consider uploading reports for the commit 757233c to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #457   +/-   ##
=======================================
  Coverage   53.25%   53.25%           
=======================================
  Files          36       36           
  Lines        1842     1842           
=======================================
  Hits          981      981           
  Misses        710      710           
  Partials      151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688ca47...757233c. Read the comment docs.

@imjasonh
Copy link
Member Author

imjasonh commented Oct 1, 2021

This seems to have found two genuine issues.

@imjasonh imjasonh merged commit dde6c6d into ko-build:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants