Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compress layers when we Build them #47

Merged
merged 1 commit into from
Jun 25, 2019
Merged

Compress layers when we Build them #47

merged 1 commit into from
Jun 25, 2019

Conversation

jonjohnsonjr
Copy link
Collaborator

This avoids double-compressing later.

On my CPU-constrained laptop, this shaves ~30% of the time off of ko publish in cases where we actually have to upload the blob.

On my pretty beefy desktop it's closer to ~15%.

@jonjohnsonjr
Compress layers when we Build them
cea64e0 
This avoids double-compressing later.
@jonjohnsonjr jonjohnsonjr requested a review from imjasonh June 25, 2019 22:53
@mattmoor mattmoor merged commit b7d1820 into ko-build:master Jun 25, 2019
@jonjohnsonjr jonjohnsonjr deleted the precompress branch June 26, 2019 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imjasonh imjasonh imjasonh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonjohnsonjr @imjasonh @mattmoor