Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use github api to generate the changelog #474

Merged
merged 1 commit into from
Oct 11, 2021
Merged

use github api to generate the changelog #474

merged 1 commit into from
Oct 11, 2021

Conversation

caarlos0
Copy link
Contributor

This gives the credits to contributors in the changelog by appending their usernames to the commits. See an example.

Its a new goreleaser feature and I particularly think is kind of cool that github now shows the avatars of contributors et al, so here it in case you folks find it interesting as well.

Signed-off-by: Carlos A Becker caarlos0@gmail.com

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
@google-cla google-cla bot added the cla: yes label Oct 11, 2021
@imjasonh
Copy link
Member

I'm totally fine with this, but I wonder whether we should prefer https://docs.github.com/en/repositories/releasing-projects-on-github/automatically-generated-release-notes once that becomes more widely supported.

@caarlos0
Copy link
Contributor Author

I'll add it to goreleaser as well once my pr on go-github is merged. The main difference is that they only list merged PRs instead of all commits...

in any case, I can change this/open another pr once its landed on goreleaser :)

@imjasonh imjasonh merged commit 6447264 into ko-build:main Oct 11, 2021
@caarlos0 caarlos0 deleted the gorel branch October 11, 2021 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants