Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use signal.NotifyContext #482

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Use signal.NotifyContext #482

merged 1 commit into from
Nov 2, 2021

Conversation

imjasonh
Copy link
Member

Fixes #292

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2021

Codecov Report

Merging #482 (cbcb2c7) into main (6447264) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #482      +/-   ##
==========================================
+ Coverage   53.13%   53.16%   +0.02%     
==========================================
  Files          36       36              
  Lines        1848     1847       -1     
==========================================
  Hits          982      982              
+ Misses        715      714       -1     
  Partials      151      151              
Impacted Files Coverage Δ
pkg/commands/apply.go 50.66% <0.00%> (-0.69%) ⬇️
pkg/commands/build.go 67.34% <0.00%> (-1.41%) ⬇️
pkg/commands/config.go 61.90% <ø> (+4.38%) ⬆️
pkg/commands/create.go 46.83% <0.00%> (-0.61%) ⬇️
pkg/commands/delete.go 42.10% <0.00%> (-2.34%) ⬇️
pkg/commands/deps.go 16.94% <0.00%> (-0.30%) ⬇️
pkg/commands/resolve.go 72.72% <0.00%> (-1.70%) ⬇️
pkg/commands/run.go 26.38% <0.00%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6447264...cbcb2c7. Read the comment docs.

Copy link
Collaborator

@jonjohnsonjr jonjohnsonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change this to use ExecuteContext and pull it from cmd.Context() in the subcommands.

@imjasonh
Copy link
Member Author

Change this to use ExecuteContext and pull it from cmd.Context() in the subcommands.

That's smart, you're smart.

@imjasonh imjasonh merged commit 1e46fde into ko-build:main Nov 2, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace createCancellableContext with signal.NotifyContext
3 participants