Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate ko deps in SPDX format #507

Merged
merged 3 commits into from
Nov 22, 2021
Merged

Generate ko deps in SPDX format #507

merged 3 commits into from
Nov 22, 2021

Conversation

imjasonh
Copy link
Member

  • copy out a bunch of BuildInfo stuff that will land in 1.18

The intention is that this should marry up with Matt's #506 so that SBOMs can be generated at image-build time.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2021

Codecov Report

Merging #507 (e5b9bbf) into main (6d06913) will decrease coverage by 0.43%.
The diff coverage is 8.69%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #507      +/-   ##
==========================================
- Coverage   51.27%   50.83%   -0.44%     
==========================================
  Files          41       41              
  Lines        2007     2028      +21     
==========================================
+ Hits         1029     1031       +2     
- Misses        807      826      +19     
  Partials      171      171              
Impacted Files Coverage Δ
pkg/commands/deps.go 15.18% <8.69%> (-2.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d06913...e5b9bbf. Read the comment docs.

pkg/commands/deps.go Outdated Show resolved Hide resolved
pkg/commands/deps.go Outdated Show resolved Hide resolved
- copy out a bunch of BuildInfo stuff that will land in 1.18
Copy link
Collaborator

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should hook this up to the other stuff now too 🎉

pkg/commands/deps.go Show resolved Hide resolved
@imjasonh imjasonh changed the title WIP: generate ko deps in SPDX format Generate ko deps in SPDX format Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants