Run golangci-lint before tool setup to fix tar errors #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #518 +/- ##
=======================================
Coverage 50.60% 50.60%
=======================================
Files 41 41
Lines 2051 2051
=======================================
Hits 1038 1038
Misses 838 838
Partials 175 175 Continue to review full report at Codecov.
|
markusthoemmes
force-pushed
the
fix-golangci-lint
branch
from
549ed70 to
394ff5f
Compare
imjasonh
approved these changes
Nov 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did the same in knative/.github. The
tarerrors are due to Golang packages already existing due to thego getorgo installcalls.