Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set config creation time without mutating #524

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Dec 6, 2021

This also sets layers' history creation times to the relevant times set in the tar files.

@imjasonh imjasonh requested a review from jonjohnsonjr December 6, 2021 16:18
@google-cla google-cla bot added the cla: yes label Dec 6, 2021
pkg/build/gobuild.go Outdated Show resolved Hide resolved
pkg/build/gobuild.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #524 (15b9ce1) into main (b813b95) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #524   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files          42       42           
  Lines        2204     2204           
=======================================
  Hits         1076     1076           
  Misses        946      946           
  Partials      182      182           
Impacted Files Coverage Δ
pkg/build/gobuild.go 57.40% <100.00%> (+0.23%) ⬆️
pkg/commands/config.go 56.25% <0.00%> (-1.13%) ⬇️
pkg/commands/resolver.go 31.55% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b813b95...15b9ce1. Read the comment docs.

@imjasonh imjasonh merged commit 8135bf2 into ko-build:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants