Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache base image metadata in-memory #525

Merged
merged 1 commit into from
Dec 8, 2021

Conversation

jonjohnsonjr
Copy link
Collaborator

This saves a roundtrip to the registry if we ever use the same base
image for multiple builds in a single invocation.

This also sets us up for using an on-disk cache for image metadata to
speed things up even further.

This saves a roundtrip to the registry if we ever use the same base
image for multiple builds in a single invocation.

This also sets us up for using an on-disk cache for image metadata to
speed things up even further.
@jonjohnsonjr jonjohnsonjr mentioned this pull request Dec 7, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #525 (4339c5f) into main (6ff3469) will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   50.58%   50.63%   +0.04%     
==========================================
  Files          40       40              
  Lines        2040     2044       +4     
==========================================
+ Hits         1032     1035       +3     
+ Misses        834      833       -1     
- Partials      174      176       +2     
Impacted Files Coverage Δ
pkg/commands/config.go 57.37% <50.00%> (+1.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ff3469...4339c5f. Read the comment docs.

@imjasonh imjasonh merged commit ad0607f into ko-build:main Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants