Set GOAMD64 if variant is set #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also changes behavior of GOARM, since docs suggest that it's only used when the GOARCH=arm, and not arm64.
Codecov Report
@@ Coverage Diff @@
## main #578 +/- ##
==========================================
+ Coverage 48.53% 48.62% +0.09%
==========================================
Files 43 43
Lines 2215 2219 +4
==========================================
+ Hits 1075 1079 +4
Misses 954 954
Partials 186 186
Continue to review full report at Codecov.
|
jonjohnsonjr
reviewed
Feb 1, 2022
jonjohnsonjr
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change also changes behavior of GOARM, since docs suggest that it's only used when the
GOARCH=arm, and notarm64.This change should benefit users using the upcoming Go 1.18 building on base images that provide amd64 with a variant specified.