Include cred helpers in keychain #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
=======================================
Coverage 48.58% 48.58%
=======================================
Files 43 43
Lines 2221 2221
=======================================
Hits 1079 1079
Misses 956 956
Partials 186 186
Continue to review full report at Codecov.
|
|
lol: https://github.com/google/ko/runs/5045688219?check_suite_focus=true Pulling distroless attempts to use gcloud auth, which is not configured, so it fails closed, instead of falling back to trying anonymous, which would succeed. 🤔 |
imjasonh
force-pushed
the
include-helpers
branch
from
6445e67 to
7443e56
Compare
This adds implicit support for Google, Amazon, Azure and GitHub container registries if the environment provides credentials. Binary size increases from 22 MB -> 26 MB
imjasonh
force-pushed
the
include-helpers
branch
from
7443e56 to
eb157b2
Compare
Closed
|
This should be RFAL now. |
chaodaiG
added a commit
to chaodaiG/test-infra
that referenced
this pull request
Mar 14, 2022
Supercedes kubernetes#25383, where in kubernetes#25383 the logic is in the pod where tests run, the problem there is that imagePullSecret defined on job pod is not accessible, which limits it's use case. The other problem is that the containers inside a test pod are not aware of the image they are from, so it's a little bit weird to let them know about it. This PR moves the logic to plank, which feels more natural ----------------------------- This is an unfortunate fact of prow, that user need to explictly set the entrypoint. The migration of prow images from being built with bazel to ko introduced a side effect of all prow jobs that use gcr.io/k8s-prow images, such as robots/comment, robots/pr-creator etc. would fail due to the location of default entrypoint change. It would be trivial amount of work to update the binary location in prow jobs definition, but would like to use this opportunity to try to get this fixed. (This PR was an effort baked on top of separate offline brainstorming with @cjwagner and @BenTheElder ) (The entrypoint extraction and docker auth parts were mainly from @imjasonh's work at ko-build/ko#581)
chaodaiG
added a commit
to chaodaiG/test-infra
that referenced
this pull request
Mar 14, 2022
Supercedes kubernetes#25383, where in kubernetes#25383 the logic is in the pod where tests run, the problem there is that imagePullSecret defined on job pod is not accessible, which limits it's use case. The other problem is that the containers inside a test pod are not aware of the image they are from, so it's a little bit weird to let them know about it. This PR moves the logic to plank, which feels more natural ----------------------------- This is an unfortunate fact of prow, that user need to explictly set the entrypoint. The migration of prow images from being built with bazel to ko introduced a side effect of all prow jobs that use gcr.io/k8s-prow images, such as robots/comment, robots/pr-creator etc. would fail due to the location of default entrypoint change. It would be trivial amount of work to update the binary location in prow jobs definition, but would like to use this opportunity to try to get this fixed. (This PR was an effort baked on top of separate offline brainstorming with @cjwagner and @BenTheElder ) (The entrypoint extraction and docker auth parts were mainly from @imjasonh's work at ko-build/ko#581)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds implicit support for Google, Amazon, Azure and GitHub container registries if the environment provides credentials.
Binary size increases from 22 MB -> 26 MB