Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --watch mode #585

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Remove --watch mode #585

merged 1 commit into from
Mar 3, 2022

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Feb 8, 2022

No description provided.

@imjasonh imjasonh marked this pull request as draft February 8, 2022 20:33
@imjasonh
Copy link
Member Author

imjasonh commented Feb 8, 2022

Let's wait until we cut v1.10 (#584) before merging this.

@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2022

Codecov Report

Merging #585 (ba05d02) into main (89ede91) will increase coverage by 1.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #585      +/-   ##
==========================================
+ Coverage   48.92%   50.06%   +1.14%     
==========================================
  Files          43       43              
  Lines        2228     2177      -51     
==========================================
  Hits         1090     1090              
+ Misses        954      903      -51     
  Partials      184      184              
Impacted Files Coverage Δ
pkg/commands/options/filestuff.go 0.00% <ø> (ø)
pkg/commands/resolver.go 35.29% <0.00%> (+4.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ede91...ba05d02. Read the comment docs.

@imjasonh imjasonh mentioned this pull request Feb 25, 2022
@imjasonh imjasonh marked this pull request as ready for review March 3, 2022 18:20
@imjasonh
Copy link
Member Author

imjasonh commented Mar 3, 2022

This is ready to go now.

@imjasonh imjasonh merged commit cd41b3e into ko-build:main Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants