Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create dir for KOCACHE #607

Merged
merged 1 commit into from
Feb 23, 2022
Merged

fix: create dir for KOCACHE #607

merged 1 commit into from
Feb 23, 2022

Conversation

developer-guy
Copy link
Collaborator

Signed-off-by: Batuhan Apaydın batuhan.apaydin@trendyol.com

Fixes #591

cc: @imjasonh

pkg/build/gobuild.go Outdated Show resolved Hide resolved
pkg/build/gobuild.go Outdated Show resolved Hide resolved
pkg/build/gobuild.go Outdated Show resolved Hide resolved
@imjasonh
Copy link
Member

We should think of some way to effectively test this behavior end to end. Maybe a test that sets KOCACHE=/tmp/$(date +%s) or something and checks that it exists after a build.

@codecov-commenter
Copy link

Codecov Report

Merging #607 (5e18df1) into main (a36ea50) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #607      +/-   ##
==========================================
- Coverage   48.51%   48.45%   -0.07%     
==========================================
  Files          43       43              
  Lines        2259     2262       +3     
==========================================
  Hits         1096     1096              
- Misses        978      981       +3     
  Partials      185      185              
Impacted Files Coverage Δ
pkg/build/gobuild.go 56.36% <0.00%> (-0.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a36ea50...5e18df1. Read the comment docs.

@jonjohnsonjr
Copy link
Collaborator

Can you rebase this to pick up the new actions config?

Signed-off-by: Batuhan Apaydın <batuhan.apaydin@trendyol.com>
@developer-guy
Copy link
Collaborator Author

developer-guy commented Feb 23, 2022

Can you rebase this to pick up the new actions config?

OFC, done 🙋🏻‍♂️

@jonjohnsonjr jonjohnsonjr merged commit d48a621 into ko-build:main Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KOCACHE directory is not created if set
4 participants