Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check if have all and other platforms set in the --platform flag #630

Merged
merged 2 commits into from
Jun 6, 2022
Merged

check if have all and other platforms set in the --platform flag #630

merged 2 commits into from
Jun 6, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 2, 2022

  • check if have all and other platforms set in the --platform flag
../../google/ko/main build --base-import-paths \
--platform=all,linux/arm --tags v1.5.1-96-gd1a4d08-dirty --tags d1a4d086309e22cc85c0c59ac662606a58c81438 github.com/sigstore/cosign/cmd/cosign
Error: validating options: all or specific platforms should be used
2022/03/02 14:12:16 error during command execution:validating options: all or specific platforms should be used
make: *** [ko] Error 1

Address #542 (comment)

/cc @imjasonh

@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #630 (57b55f2) into main (e4a01f6) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #630      +/-   ##
==========================================
- Coverage   51.47%   51.40%   -0.08%     
==========================================
  Files          44       44              
  Lines        3279     3284       +5     
==========================================
  Hits         1688     1688              
- Misses       1380     1385       +5     
  Partials      211      211              
Impacted Files Coverage Δ
pkg/commands/options/validate.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4a01f6...57b55f2. Read the comment docs.

imjasonh
imjasonh previously approved these changes Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 6, 2022

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Keep fresh with the 'lifecycle/frozen' label.

Signed-off-by: cpanato <ctadeu@gmail.com>
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
Copy link
Member Author

cpanato commented Jun 6, 2022

rebased

@imjasonh imjasonh merged commit c08133d into ko-build:main Jun 6, 2022
@cpanato cpanato deleted the GH-542-build branch June 6, 2022 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants