Allow skipping TLS verification while publishing image #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why this is necessary: when using a local docker registry, users may not want to support https, or there may be other troubles not allowing verifiable TLS support. This commit adds this functionality by adding an `--insecure-registry` flag.
jonjohnsonjr
approved these changes
Jul 24, 2019
There was a problem hiding this comment.
LGTM, thanks!
I was thinking that we'd have it be similar to docker where you have to supply the registry as the flag value, but then I realized it will only ever have one value (KO_DOCKER_REPO). We could do something cute like allowing KO_DOCKER_REPO to be prefixed by http:// to signal that it's insecure instead of having a flag, but I think this is fine.
This won't apply to the base image currently (which is fine), but we may want to plumb this down to the builder eventually if someone runs into that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this is necessary: when using a local docker registry, users may not
want to support https, or there may be other troubles not allowing
verifiable TLS support.
This commit adds this functionality by adding an
--insecure-registryflag.
@jonjohnsonjr
Fixes #64