Update base image to ghcr.io/distroless/static:latest #737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm ok to merge this but with the caveat that I wouldn't hesitate to revert it if something unexpectedly breaks. |
Codecov Report
@@ Coverage Diff @@
## main #737 +/- ##
=======================================
Coverage 51.38% 51.38%
=======================================
Files 44 44
Lines 3295 3295
=======================================
Hits 1693 1693
Misses 1390 1390
Partials 212 212
Continue to review full report at Codecov.
|
jonjohnsonjr
approved these changes
Jun 30, 2022
5 tasks
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #722
ghcr.io/distroless/staticnow includes tzdata, but this also adds a test that ensures timezone conversions are unaffected in case we change the base image again in the future.I don't want to update the README until after we cut a release.