Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove deprecated k8s flags support #750

Merged
merged 1 commit into from
Jul 13, 2022
Merged

remove deprecated k8s flags support #750

merged 1 commit into from
Jul 13, 2022

Conversation

imjasonh
Copy link
Member

@imjasonh imjasonh commented Jul 6, 2022

Mentioned in #748

Support for kubectl flags in ko apply and ko create has been deprecated since #413 (466dbab), merged Aug 2021, released in v0.9 (Sept 2021).

@imjasonh imjasonh requested a review from jonjohnsonjr July 6, 2022 13:52
@imjasonh imjasonh added this to the 0.12 milestone Jul 7, 2022
@imjasonh imjasonh merged commit ca1648d into ko-build:main Jul 13, 2022
abayer added a commit to abayer/tektoncd-pipeline that referenced this pull request Aug 30, 2022
@abayer
Fix TestYamls for change in ko create
29bafa6 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer mentioned this pull request Aug 30, 2022
Merged
7 tasks
abayer added a commit to abayer/tektoncd-pipeline that referenced this pull request Aug 30, 2022
@abayer
Fix TestYamls for change in ko create
62a383e 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer added a commit to abayer/tektoncd-pipeline that referenced this pull request Aug 30, 2022
@abayer
Fix TestYamls for change in ko create
df12ce0 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot pushed a commit to tektoncd/pipeline that referenced this pull request Aug 31, 2022
@abayer @tekton-robot
Fix TestYamls for change in ko create
a1ca389 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
abayer added a commit to abayer/tektoncd-pipeline that referenced this pull request Sep 6, 2022
@abayer
Fix TestYamls for change in ko create
f64d840 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer mentioned this pull request Sep 6, 2022
Merged
7 tasks
abayer added a commit to abayer/tektoncd-pipeline that referenced this pull request Sep 6, 2022
@abayer
Fix TestYamls for change in ko create
36f36b9 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer mentioned this pull request Sep 6, 2022
Merged
7 tasks
abayer added a commit to abayer/tektoncd-pipeline that referenced this pull request Sep 6, 2022
@abayer
Fix TestYamls for change in ko create
62aa8ec 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
@abayer abayer mentioned this pull request Sep 6, 2022
Merged
7 tasks
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this pull request Sep 6, 2022
@abayer
Fix TestYamls for change in ko create
da3de27 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot pushed a commit to tektoncd/pipeline that referenced this pull request Sep 6, 2022
@abayer @tekton-robot
Fix TestYamls for change in ko create
9937ec3 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot pushed a commit to tektoncd/pipeline that referenced this pull request Sep 6, 2022
@abayer @tekton-robot
Fix TestYamls for change in ko create
42cdeb4 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot pushed a commit to tektoncd/pipeline that referenced this pull request Sep 6, 2022
@abayer @tekton-robot
Fix TestYamls for change in ko create
5e4167a 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot pushed a commit to tekton-robot/pipeline that referenced this pull request Sep 6, 2022
@abayer
Fix TestYamls for change in ko create
bc0d120 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
tekton-robot pushed a commit to tektoncd/pipeline that referenced this pull request Sep 7, 2022
@abayer @tekton-robot
Fix TestYamls for change in ko create
f7e8a56 
With ko-build/ko#750, which we picked up when we bumped `ko` to `v0.12.0` in the test-runner image, `-n (namespace)` is no longer an argument for `ko create`. So we need to ensure that the namespace for the `TestYamls` CRDs is actually set properly, and get rid of the `-n (namespace)` from our invocation of `ko create`.

Signed-off-by: Andrew Bayer <andrew.bayer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonjohnsonjr jonjohnsonjr jonjohnsonjr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.12
Development

Successfully merging this pull request may close these issues.
2 participants
@imjasonh @jonjohnsonjr