Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up in the discussion of #684 -- the
-toolexec
flag makesgo build
execute another command, and generally represents pretty non-standard, advanced usage. A bad build config could set-toolexec not-go
and getnot-go
to be executed bygo
instead of the regular Go toolchain.ko
aims to make normal usage easy and secure, even if it rejects advanced use cases (e.g.,CGO_ENABLED
), so we'll just reject-trimpath
if it's requested.