Several SPDX SBOM adjustments. #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change index -> image relationship type from `CONTAINS` to `VARIANT_OF` (I think this was an oversight in my original PR), 2. Always include `mediaType` in pURLs for index/images we produce (I'm not adding this to the base image, since it's not readily available, but we can add it there if we want to find a way to plumb it through), 3. Include more platform discriminator information to the pURLs we use in index -> image.
imjasonh
reviewed
Jul 11, 2022
| Related: depID, | ||
| }) | ||
|
|
||
| qual := []qualifier{{ |
There was a problem hiding this comment.
This makes me want a newQualifier(k, v string) qualifier helper method, and/or a platformQualifiers(p v1.Platform) []qualifier.
There was a problem hiding this comment.
Yeah, it's worth surveying our usage of qualifiers as this evolves and figuring out what helpers make sense. I'd also be inclined to just create a decent OCI pURL library in GGCR and use that TBH.
imjasonh
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONTAINStoVARIANT_OF(I think this was an oversight in my original PR),mediaTypein pURLs for index/images we produce (I'm not adding this to the base image, since it's not readily available, but we can add it there if we want to find a way to plumb it through),cc @puerco